On Fri, 14 Feb 2025 at 08:20, Anusha Srivatsa <asrivats@xxxxxxxxxx> wrote:
>
> Replace platform_get_resource + devm_ioremap
> with just devm_platform_ioremap_resource()
>
> Used Coccinelle to do this change. SmPl patch:
> @rule_2@
> identifier res;
> expression ioremap;
> identifier pdev;
> @@
> -struct resource *res;
> ...
> -res = platform_get_resource(pdev,...);
> <...
> -if (!res) {
> -...
> -}
> ...>
> -ioremap = devm_ioremap(...);
> +ioremap = devm_platform_ioremap_resource(pdev,0);
>
> Cc: Chunyan Zhang <zhang.lyra@xxxxxxxxx>
> Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Reviewed-by: Maxime Ripard <mripard@xxxxxxxxxx>
> Signed-off-by: Anusha Srivatsa <asrivats@xxxxxxxxxx>
> ---
> drivers/gpu/drm/sprd/sprd_dpu.c | 9 +--------
> drivers/gpu/drm/sprd/sprd_dsi.c | 9 +--------
> 2 files changed, 2 insertions(+), 16 deletions(-)
>
Reviewed-by: Chunyan Zhang <zhang.lyra@xxxxxxxxx>
Thanks,
Chunyan
> diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c
> index cb2816985305fd19eac27413c214681a5a1e9ffa..65cd5aa1634eee5a6735ccffa4ee3979844d92ce 100644
> --- a/drivers/gpu/drm/sprd/sprd_dpu.c
> +++ b/drivers/gpu/drm/sprd/sprd_dpu.c
> @@ -784,16 +784,9 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu,
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct dpu_context *ctx = &dpu->ctx;
> - struct resource *res;
> int ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "failed to get I/O resource\n");
> - return -EINVAL;
> - }
> -
> - ctx->base = devm_ioremap(dev, res->start, resource_size(res));
> + ctx->base = devm_platform_ioremap_resource(pdev, 0);
> if (!ctx->base) {
> dev_err(dev, "failed to map dpu registers\n");
> return -EFAULT;
> diff --git a/drivers/gpu/drm/sprd/sprd_dsi.c b/drivers/gpu/drm/sprd/sprd_dsi.c
> index 8fc26479bb6bce0aa94914f49d0986a7e19326c1..1668bb4166ab0ad3812c5654244544a9caf249a6 100644
> --- a/drivers/gpu/drm/sprd/sprd_dsi.c
> +++ b/drivers/gpu/drm/sprd/sprd_dsi.c
> @@ -901,15 +901,8 @@ static int sprd_dsi_context_init(struct sprd_dsi *dsi,
> {
> struct platform_device *pdev = to_platform_device(dev);
> struct dsi_context *ctx = &dsi->ctx;
> - struct resource *res;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!res) {
> - dev_err(dev, "failed to get I/O resource\n");
> - return -EINVAL;
> - }
> -
> - ctx->base = devm_ioremap(dev, res->start, resource_size(res));
> + ctx->base = devm_platform_ioremap_resource(pdev, 0);
> if (!ctx->base) {
> drm_err(dsi->drm, "failed to map dsi host registers\n");
> return -ENXIO;
>
> --
> 2.47.0
>
