On Sat, 01 Feb 2025, Manuel Fombuena wrote: > Arguably, there are more chances of errors occurring during the > initialization of the hardware, so this should complete successfully > before the DT node childreen are initialized. Okay. And you're sure nothing in Setup needs the DT info? > Signed-off-by: Manuel Fombuena <fombuena@xxxxxxxxxxx> > --- > drivers/leds/leds-st1202.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c > index e894b3f9a0f4..927874f20839 100644 > --- a/drivers/leds/leds-st1202.c > +++ b/drivers/leds/leds-st1202.c > @@ -348,11 +348,11 @@ static int st1202_probe(struct i2c_client *client) > devm_mutex_init(&client->dev, &chip->lock); > chip->client = client; > > - ret = st1202_dt_init(chip); > + ret = st1202_setup(chip); > if (ret < 0) > return ret; > > - ret = st1202_setup(chip); > + ret = st1202_dt_init(chip); > if (ret < 0) > return ret; > > -- > 2.48.1 > -- Lee Jones [李琼斯]
