On Mon, 10 Feb 2025 18:50:47 -0800 Joe Damato wrote: > On Mon, Feb 10, 2025 at 06:16:35PM -0800, Jakub Kicinski wrote: > > On Sat, 8 Feb 2025 01:28:21 +0000 Joe Damato wrote: > > > +Persistent NAPI config > > > +---------------------- > > > + > > > +Drivers can opt-in to using a persistent NAPI configuration space by calling > > > > Should we be more forceful? I think for new drivers the _add_config() > > API should always be preferred given the benefits. > > How about: "Drivers should opt-in ..." instead? I have no strong > preference. A bit more editing may be beneficial, lead with the problem: Drivers often allocate and free NAPI instances dynamically. This leads to loss of NAPI-related user configuration, each time NAPI instances are reallocated. The netif_napi_add_config() API prevents this loss of configuration by associating each NAPI instance with... Drivers should try to use netif_napi_add_config() whenever possible.
