Re: [PATCH] docs: submitting-patches: document the format for affiliation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Kicinski <kuba@xxxxxxxxxx> writes:

> Adding company name in round brackets to From/SoB lines
> is fairly common, but I don't see it documented anywhere.
> Every now and then people try to add the sponsorship lines
> to the commit message, fun example from this merge window:
>
>   Sponsored by:   The FreeBSD Foundation
>
> from commit 2ce67f8bf1ce ("wifi: iwlwifi: mvm: fix iwl_ssid_exist()
> check"). Better format would be:
>
>   Author: Miri Korenblit (FreeBSD Foundation) <...
>
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> ---
> CC: corbet@xxxxxxx
> CC: workflows@xxxxxxxxxxxxxxx
> CC: linux-doc@xxxxxxxxxxxxxxx
> ---
>  Documentation/process/submitting-patches.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
> index 8fdc0ef3e604..12ed28b3d113 100644
> --- a/Documentation/process/submitting-patches.rst
> +++ b/Documentation/process/submitting-patches.rst
> @@ -717,6 +717,12 @@ patch in the permanent changelog.  If the ``from`` line is missing,
>  then the ``From:`` line from the email header will be used to determine
>  the patch author in the changelog.
>  
> +The author may indicate their affiliation or the sponsor of the work
> +by adding the name of an organization to the ``from`` and ``SoB`` lines,
> +e.g.:
> +
> +	From: Patch Author (Company) <author@xxxxxxxxxxx>
> +
>  Explanation Body
>  ^^^^^^^^^^^^^^^^

So, despite all the conversation, I didn't see any real opposition to
adding this change, so I've applied it.

Amusingly, b4 helpfully picked up these tags from the conversation:

 + Signed-off-by: John Doe <jdoe@xxxxxxxxxxx> (✓DKIM/infradead.org)
 + Signed-off-by: Mr Maintainer <jdoe@xxxxxxxxxxx> (✓DKIM/kernel.org)
 + Signed-off-by: Jane Maintainer <jdoe@xxxxxxxxxxx>

Tempting as it was to leave them in, I took them out :)

Thanks,

jon





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux