On Mon, 3 Feb 2025 15:31:27 +0200
Alisa-Dariana Roman <alisadariana@xxxxxxxxx> wrote:
> AD7191 is a pin-programmable, ultra-low noise 24-bit sigma-delta ADC
> designed for precision bridge sensor measurements. It features two
> differential analog input channels, selectable output rates,
> programmable gain, internal temperature sensor and simultaneous
> 50Hz/60Hz rejection.
>
> Signed-off-by: Alisa-Dariana Roman <alisa.roman@xxxxxxxxxx>
Hi,
Just one trivial additional comment from me as you'll be doing a v5
anyway. If it had just been this I'd have tweaked it whilst applying.
Thanks,
Jonathan
> diff --git a/drivers/iio/adc/ad7191.c b/drivers/iio/adc/ad7191.c
> new file mode 100644
> index 000000000000..4a9e66853294
> --- /dev/null
> +++ b/drivers/iio/adc/ad7191.c
> +static int ad7191_setup(struct iio_dev *indio_dev, struct device *dev)
dev isn't used, so drop that parameter.
> +{
> + struct ad7191_state *st = iio_priv(indio_dev);
> + int ret;
> +
> + ret = ad7191_init_regulators(indio_dev);
> + if (ret)
> + return ret;
> +
> + ret = ad7191_config_setup(indio_dev);
> + if (ret)
> + return ret;
> +
> + return ad7191_clock_setup(st);
> +}
