On Thu, Feb 6, 2025 at 11:41 AM Maciej Wieczor-Retman <maciej.wieczor-retman@xxxxxxxxx> wrote: > > >I started reviewing the patches, but this is somewhat complicated, as > >the dense mode changes are squashed together with the generic ones for > >x86 support. Could you please split this series into 2? Or at least > >reorder the patches so that everything needed for basic x86 support > >comes first and can be reviewed and tested separately. > > I'll try reordering first and see if it looks nice. Since the dense mode would > make some parts arch specific I think it's better to have the two parts in one > series for easier reference. But if it turns out more convoluted I'll just split > it as you suggested. Yes, please do. I also think if you split the series, we can land the basic x86 support fairly quickly, or at least I can do the review and give the ack from the KASAN side. For the dense mode part, I'd like to also hear the opinion of other KASAN developers wrt the overall design. > >Also feel free to drop the dependency on that risc-v series, as it > >doesn't get updated very often. But up to you. > > Okay, I was mostly interested in the patch that redefines KASAN_SHADOW_END as > KASAN_SHADOW_OFFSET and then gets shadow addresses by using a signed offset. But > I suppose I can just take that patch and prepend my series with that? (after > applying your comments from that series) Sounds good to me!
