On Wed, Feb 05, 2025 at 10:21:30PM -0700, Uday Shankar wrote: > There are a few places in the tree which compute the length of the > string representation of a MAC address as 3 * ETH_ALEN - 1. Define a > constant for this and use it where relevant. No functionality changes > are expected. > > Signed-off-by: Uday Shankar <ushankar@xxxxxxxxxxxxxxx> > --- > drivers/net/netconsole.c | 2 +- > drivers/nvmem/brcm_nvram.c | 2 +- > drivers/nvmem/layouts/u-boot-env.c | 2 +- > include/linux/if_ether.h | 3 +++ > lib/net_utils.c | 4 +--- > net/mac80211/debugfs_sta.c | 5 +++-- > 6 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c > index 86ab4a42769a49eebe5dd6f01dafafc6c86ec54f..6db5af2d8d059fa5c072194545d4408eec19b4a9 100644 > --- a/drivers/net/netconsole.c > +++ b/drivers/net/netconsole.c > @@ -675,7 +675,7 @@ static ssize_t remote_mac_store(struct config_item *item, const char *buf, > [...] What about ieee80211_sta_debugfs_add()? (net/mac80211/debugfs_sta.c) In gerneal looks fine, thanks: Reviewed-by: Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx> > > -- > 2.34.1
