On 2025-02-04 8:18 pm, Wei Huang wrote:
On 2/4/25 12:33 PM, Robin Murphy wrote:
On 2024-10-02 5:59 pm, Wei Huang wrote:
[...]
+
+ if (err) {
+ pcie_disable_tph(pdev);
+ return err;
+ }
+
+ set_ctrl_reg_req_en(pdev, pdev->tph_mode);
Just looking at this code in mainline, and I don't trust my
understanding quite enough to send a patch myself, but doesn't this want
to be pdev->tph_req_type, rather than tph_mode?
Yeah, you are right - this is supposed to be pdev->tph_req_type instead
of tph_mode. We disable TPH first by clearing (zero) the "TPH Requester
Enable" field and needs to set it back using tph_req_type.
Do you want to send in a fix? I can ACK it. Thanks for spotting it.
Done[1] - cheers for confirming!
Robin.
[1]
https://lore.kernel.org/linux-pci/13118098116d7bce07aa20b8c52e28c7d1847246.1738759933.git.robin.murphy@xxxxxxx/
-Wei
Thanks,
Robin.
