On Tue, 2025-02-04 at 14:41 -0700, Uday Shankar wrote: > There are a few places in the tree which compute the length of the > string representation of a MAC address as 3 * ETH_ALEN - 1. Define a > constant for this and use it where relevant. No functionality changes > are expected. True ... but is "MAC_ADDR_LEN" really an appropriate name for that? Just plain reading the subject, my first thought was why you weren't going to use ETH_ALEN. Would seem nicer to me, at least, to have something indicating a *string* in there, e.g. MAC_ADDR_STR_LEN or so. johannes
