On Tue, Feb 04, 2025 at 07:18:34AM -0800, Jakub Kicinski wrote: > On Tue, 4 Feb 2025 08:59:28 +0100 Geert Uytterhoeven wrote: > > You probably also want to document the other popular[*] solution: > > > > From: Patch Author <author+company@xxxxxxxxxxx> > > > > [*] Statistics for v6.0..v6.14-rc1: > > - "(Company): 3430 > > - "+company": 2871 > > Hm, I mostly associate that format with MAINTAINERS entries where > people want email classification. But you're right there are some > uses, only 3 of them look like companies, tho. > > $ git log --format='%ae' v6.0..v6.14-rc1 | grep '+' | sed -e 's/.*+\(.*\)@.*/\1/' | sort | uniq -c | awk '{if ($1 > 5) print;}' > 18 huawei > 464 kernel > 46 lin > 742 linaro > 8 publicgit > 1646 renesas > > $ git log --format='%an' v6.0..v6.14-rc1 | sed -n 's/.*(\(.*\))/\1/p' | sort | uniq -c | awk '{if ($1 > 5) print;}' > 177 AMD > 210 Arm > 29 Dent Project > 37 eBPF Foundation > 547 Google > 13 Hanghong Ma > 132 IBM > 46 Intel > 38 Microsoft > 18 Ming Qiang Wu > 155 NGI0 > 26 NXP OSS > 1487 Oracle > 19 OSS > 7 Som > 70 Sony > 353 SUSE > 9 tencent > 24 VMware > 8 辛安文 Note that some of those are name components: 7 Somashekhar(Som) <somashekhar.puttagangaiah@xxxxxxxxx> 13 Leo (Hanghong) Ma <hanghong.ma@xxxxxxx> 18 David (Ming Qiang) Wu <David.Wu3@xxxxxxx> In two cases the component between parentheses is in the middle of the name, so it can be differentiated from a company name, but that's not always the case. Automatic parsing of author names (or other tags) is ambiguous. We also have cases where the additional text refers to a team within a company, already properly identified by the e-mail address: 15 Jan Petrous (OSS) <jan.petrous@xxxxxxxxxxx> 26 Radu Pirea (NXP OSS) <radu-nicolae.pirea@xxxxxxxxxxx> Or apparently project or customer names for consulting companies: 29 Kory Maincent (Dent Project) <kory.maincent@xxxxxxxxxxx> 34 Alexis Lothoré (eBPF Foundation) <alexis.lothore@xxxxxxxxxxx> The other cases correctly refer to companeis, for contributors using other email addresses: 14 linux.dev 41 zytor.com 47 joelfernandes.org 176 alien8.de 243 gmail.com 333 goodmis.org 454 armlinux.org.uk 918 infradead.org 1007 kernel.org Do we want to only document existing practices, or also tell which one(s) should be favoured ? -- Regards, Laurent Pinchart