On 2/3/25 11:39 PM, Mina Almasry wrote: > The TX path had been dropped from the Device Memory TCP patch series > post RFCv1 [1], to make that series slightly easier to review. This > series rebases the implementation of the TX path on top of the > net_iov/netmem framework agreed upon and merged. The motivation for > the feature is thoroughly described in the docs & cover letter of the > original proposal, so I don't repeat the lengthy descriptions here, but > they are available in [1]. > > Sending this series as RFC as the winder closure is immenient. I plan on > reposting as non-RFC once the tree re-opens, addressing any feedback > I receive in the meantime. I guess you should drop this paragraph. > Full outline on usage of the TX path is detailed in the documentation > added in the first patch. > > Test example is available via the kselftest included in the series as well. > > The series is relatively small, as the TX path for this feature largely > piggybacks on the existing MSG_ZEROCOPY implementation. It looks like no additional device level support is required. That is IMHO so good up to suspicious level :) > Patch Overview: > --------------- > > 1. Documentation & tests to give high level overview of the feature > being added. > > 2. Add netmem refcounting needed for the TX path. > > 3. Devmem TX netlink API. > > 4. Devmem TX net stack implementation. It looks like even the above section needs some update. /P