On Mon, Feb 03, 2025 at 04:10:24PM +0100, Andrew Lunn wrote: > > Conversely, spelling and grammar fixes are not discouraged. > > > > +Inline functions > > +---------------- > > + > > +The use of static inline functions in .c file is strongly discouraged > > I don't think 'static' is relevant here. They probably are static, if > they are inline, and to avoid warnings about missing declarations. But > we just prefer not to have any sort of inline functions without good > justifications within a .c file. > > A nit pick, so: > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Thanks Andrew, I agree that static is not helpful here, I'll drop that in a v2.