Hi Louis, Thanks a lot for the patches. I'm not well versed in YUV color formats, so I did my best reading the kernel documentation before reviewing this series... But I'll most likely ask some basic/dump questions. > From: Arthur Grillo <arthurgrillo@xxxxxxxxxx> > > VKMS has support for YUV formats now. Remove the task from the TODO > list. > > Signed-off-by: Arthur Grillo <arthurgrillo@xxxxxxxxxx> > Signed-off-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx> > --- > Documentation/gpu/vkms.rst | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst > index ba04ac7c2167a9d484c54c69a09a2fb8f2d9c0aa..13b866c3617cd44043406252d3caa912c931772f 100644 > --- a/Documentation/gpu/vkms.rst > +++ b/Documentation/gpu/vkms.rst > @@ -122,8 +122,7 @@ There's lots of plane features we could add support for: > > - Scaling. > > -- Additional buffer formats, especially YUV formats for video like NV12. > - Low/high bpp RGB formats would also be interesting. > +- Additional buffer formats. Low/high bpp RGB formats would be interesting. I see that you implemented support for 6 DRM_FORMAT_NV* formats, but DRM_FORMAT_NV15, DRM_FORMAT_NV20 and DRM_FORMAT_NV30 are not implemented. The same applies to DRM_FORMAT_Y210 or DRM_FORMAT_YUV410 among others. Could it be useful to implement all of them in the future? If so, should we add it to the ToDo list? It might be a great task to get started in kernel development, as there are already similar examples and tests. > > - Async updates (currently only possible on cursor plane using the legacy > cursor api). >
