Re: [PATCH 1/2] docs/ja_JP: Convert SubmitChecklist into reST with belated updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, Shibata-san,

Glad to hearing from you!
That said, your reply was in the html format and the linux-doc list
didn't accept it.  You are supposed to send in plain text.

Here are my responses to your comments, with manual conversion of your
message into plain text and indentation tweaks.

Tsugikazu Shibata wrote:
> Hello, Here are my comments:
> 
> On Tue, Jan 28, 2025 at 7:38 PM Akira Yokosawa <akiyks@xxxxxxxxx <mailto:akiyks@xxxxxxxxx>> wrote:
>> 
>> This is actually a brand-new translation against
>> commit 47c67ec1e8ef ("docs: submit-checklist: use subheadings"),
>> rather than an update of existing SubmitChecklist.
>> 
>> As we now have two reST contents under the ja_JP translation,
>> to avoid duplicated boiler plates, split out the disclaimer part
>> into a new section and put reference to it at the beginning of each
>> doc.
>> 
>> As there is no prospect of ja_JP to have a lot of translated docs,
>> keep those .rst files in the toctree of ja_JP/index.rst.
>> 
>> Signed-off-by: Akira Yokosawa <akiyks@xxxxxxxxx>
>> Cc: Tsugikazu Shibata <shibata@xxxxxxxxxxxxxxxxxxx>
>> ---
>> .../translations/ja_JP/SubmitChecklist        | 105 -----------
>> .../translations/ja_JP/disclaimer-ja_JP.rst   |  22 +++
>> Documentation/translations/ja_JP/index.rst    |   2 +
>> .../translations/ja_JP/process/howto.rst      |  37 ++--
>> .../ja_JP/process/submit-checklist.rst        | 165 ++++++++++++++++++
>> 
>> 
> ...
> 
>> diff --git a/Documentation/translations/ja_JP/process/submit-checklist.rst b/Documentation/translations/ja_JP/process/submit-checklist.rst
>> new file mode 100644
>> index 000000000000..b9da826d30ae
>> --- /dev/null
>> +++ b/Documentation/translations/ja_JP/process/submit-checklist.rst
>> @@ -0,0 +1,165 @@
>> +.. SPDX-License-Identifier: GPL-2.0
>> +
>> +.. Translated by Akira Yokosawa <akiyks@xxxxxxxxx <mailto:akiyks@xxxxxxxxx>>
>> +
>> +.. In the past, translation of this document of a different origin was
>> +   at Documentation/translations/ja_JP/SubmitChecklist, which can be found
>> +   in the pre-v6.14 tree if you are interested.
>> +   Please note that this translation is independent of the previous one.
>> +
>> +======================================
>> +Linux カーネルパッチ投稿チェックリスト
>> +======================================
>> +
>> +.. note::
>> +   この文書は、
>> +   Documentation/process/submit-checklist.rst
>> +   の翻訳です。
>> +   免責条項については、
>> +   :ref:`translations_ja_JP_disclaimer` および
>> +   :ref:`translations_disclaimer` を参照してください。
>> +
>> +以下は、カーネルパッチの投稿時に、そのスムーズな受け入れのために心がける
>> +べき基本的な事項です。
>> +
>> +これは、 Documentation/process/submitting-patches.rst およびその他の
>> +Linux カーネルパッチ投稿に関する文書を踏まえ、それを補足するものです。
>> +
>> +.. note::
>> +   【訳註】チェックリストらしくするため、問い掛けの語尾を多用します。
>> +   また、原義を損なわない範囲で、主語の省略、主語に係る修飾子の述語に係る
>> +   修飾子への変更、能動態への言い換えなどを行い、より簡潔で把握しやすい
>> +   箇条書きを目指します。
>> 
> 
> I feel uncomfortable with these notes.
> Original text of sumitting-patches is the list of TODOs. 

Of course you mean submit-checklist.rst ...

> That is basically saying "Do something" type of lists.

Do you read the list that way?

I don't think so.  It's a mixture of suggestions made in various grammatical
structures.

For example, here is an item in original submit-checklist.rst:

  3) All memory barriers {e.g., ``barrier()``, ``rmb()``, ``wmb()``} need a
     comment in the source code that explains the logic of what they are doing
     and why.

I don't think this is in the form of TODO.  Rather, it implies what you
should do, in a sentence whose subject is "All memory barriers".
So I don't think it is worth preserving wording in the original.
List of "What you are supposed to have done before submission"
is much straight forward, isn't it?

Documentation/translation/index.rst has this paragraph in its "Disclaimer":

  Translations try to be as accurate as possible but it is not possible to map
  one language directly to all other languages. Each language has its own
  grammar and culture, so the translation of an English statement may need to be
  adapted to fit a different language.  For this reason, when viewing
  translations, you may find slight differences that carry the same message but
  in a different form.

Of course, I might be too aggressive in ignoring original wording.

> However, your translation is being "Did you do something" type.
> That is not a straightforward translation and may not tell what the
> original version says.

Can you please tell me where my translation is *not* telling what the
original does?

> This document will live long years and straightforwardness is one of
> the keys to maintain.

If you have trouble with my way of translation, please submit a patch
to "fix" it.  I'd be glad to review your changes with my ja_JP
documentation reviewer hat on.

> I will add some examples below;
> 
>> +
>> +
>> +コードのレビュー
>> +================
>> +
>> +1) 利用している機能について、その機能が定義・宣言されているファイルを
>> +   ``#include`` したか。
>> +   他のヘッダーファイル経由での取り込みに依存しないこと。
>> 
> 
> The recommended changes would be
> 1) 利用している機能について、その機能が定義・宣言されているファイルを ``#include`` すること。 
> 他のヘッダーファイル経由での取り込みに依存しないこと。
>  
> 
>> +
>> +2) Documentation/process/coding-style.rst に詳述されている一般的なスタイル
>> +   についてチェックしたか。
> 
> 
> 2) Documentation/process/coding-style.rst に詳述されている一般的なスタイル
> についてチェックすること。
> All others are the same.
>  
> 
...
>> +
>> +.. note::
>> +   【訳註】採用した訳語
>> +
>> +   - build farm: ビルド環境
>> +   - brainpower: 知力
>> +   - fault injection: 誤り注入
> 
> 
> I believe the word "誤り注入" is not oftenly used in the Japanese kernel developers.
> Insted、 "フォールトインジェクション” could be used. It is enough.

Yes, I'm fully aware of that.  Otherwise, I would not have added that
note on my choices of translation words.  Do I need to say
"【訳註】一般的でない訳語の選択" or "[translation note] Choices of-
uncommon translation terms" ?

I am a strong hater of transliteration which just bloats translated
text and makes it harder to read.  Why?  It takes longer to recognize.
Sometimes, my brain performs reverse transliteration of a *long*
KATAKANA term when I see.
To me, keeping English terms as are in the translation would be a much
better approach.

Jon, I'll post patch 2/2 in this set as an English-only change so that
you can apply it sooner rather than later.

        Thanks, Akira





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux