On Wed, Jan 29, 2025 at 03:41:32PM +0100, Thierry Reding wrote: > On Wed, Jan 29, 2025 at 03:31:50PM +0100, Maxime Ripard wrote: > > Hi Thomas, > > > > On Wed, Jan 29, 2025 at 02:06:15PM +0100, Thomas Zimmermann wrote: > > > Am 28.01.25 um 23:29 schrieb Anusha Srivatsa: > > > > Remove the TODO now that this series addresses > > > > the changes needed. > > > > > > While your series is fine, this TODO item is unrelated. It's about various > > > ancient fbdev drivers that do not reserve their memory regions correctly. So > > > please drop patch 14 form the series. > > > > Is it? Could we rephrase the entry then? I'm the one that suggested > > Anusha to work on this, and it's still not clear to me what it means > > exactly if it's not what she worked on :) > > The text in the TODO sounds pretty clear to me. The title is "Request memory regions in all drivers", and the first sentence is "Go through all drivers and add code to request the memory regions that the driver uses". It's definitely ambiguous if only fbdev drivers should be considered, even more so in the DRM documentation. > It says that not all drivers request the memory that they are going to > use, and suggests to add those missing calls. Right. > But all of the drivers in this series already do that Nope. > and the only change here is to convert them to use some of the newer > helpers. For some, yes. For others, it actually adds request_mem_region. Maxime
Attachment:
signature.asc
Description: PGP signature
