On Tue, 17 Dec 2013, Krzysztof Kozlowski wrote:
> On Tue, 2013-12-17 at 13:51 +0000, Lee Jones wrote:
> > > Add symbols for hard-coded values of BUCK_RAMP field in DVS_RAMP
> > > register. This simplifies a little the code as register update is called
> > > only once.
> > >
> > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> > > Cc: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> > > Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> > > ---
> > > drivers/regulator/s5m8767.c | 22 ++++++++++------------
> > > include/linux/mfd/samsung/s5m8767.h | 15 +++++++++++++++
> > > 2 files changed, 25 insertions(+), 12 deletions(-)
> >
> > <snip>
> >
> > > diff --git a/include/linux/mfd/samsung/s5m8767.h b/include/linux/mfd/samsung/s5m8767.h
> > > index 9198377ee859..2ab0b0f03641 100644
> > > --- a/include/linux/mfd/samsung/s5m8767.h
> > > +++ b/include/linux/mfd/samsung/s5m8767.h
> > > @@ -186,4 +186,19 @@ enum s5m8767_regulators {
> > > #define S5M8767_ENCTRL_SHIFT 6
> > > #define S5M8767_ENCTRL_MASK (0x3 << S5M8767_ENCTRL_SHIFT)
> > >
> > > +/*
> > > + * Values for BUCK_RAMP field in DVS_RAMP register, matching raw values
> > > + * in mV/us.
> > > + */
> > > +enum s5m8767_dvs_buck_ramp_values {
> > > + S5M8767_DVS_BUCK_RAMP_5 = 0x4,
> > > + S5M8767_DVS_BUCK_RAMP_10 = 0x9,
> > > + S5M8767_DVS_BUCK_RAMP_12_5 = 0xb,
> > > + S5M8767_DVS_BUCK_RAMP_25 = 0xd,
> > > + S5M8767_DVS_BUCK_RAMP_50 = 0xe,
> > > + S5M8767_DVS_BUCK_RAMP_100 = 0xf,
> > > +};
> >
> > Why do these have to be enums?
>
> There is no special need. I chose enum because it is a kind of
> enumeration of all valid values for BUCK_RAMP field (valid according to
> datasheet). If you prefer #define then I'll change it.
I'm not fussed enough to make you resubmit.
Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
