Re: [PATCH] docs: Fix backticks in README instructions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[+CC: Jon]
Hi,

Not a comment on the patch contents, just nitpicking.

carlodelos90 wrote:
> The commands 'make pdfdocs' and make 'htmldocs' were formatted with backticks. which caused confusion in some contexts, like GitHub. However, using tripple backticks is not universally compatible.
> 
> This patch replaces backticks with normal quotes to ensure clarity and compatibility across all rendering contexts.
> 
> Signed-off-by: Carlo K <carlodelos90@xxxxxxxxx>

I'd suggest you to run scripts/checkpatch.pl on your patch.
It is good in catching issues in patches especially from new contributors.

Besides that, you have failed to denote a patch version.

I'd say [PATCH v2] in the subject of this patch.  Next one will be v3.

As we are in the middle of the merge window, I'd suggest you to take
some time and skim through documents under Documentation/process/,
especially submitting-patches.rst and submit-checklist.rst among others,
before submitting a v3.

Questions are always welcome!

Thanks, Akira





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux