Hi Shawn, >From: Shawn Guo [mailto:shawn.guo@xxxxxxxxxx] >>On Tue, Dec 17, 2013 at 05:00:53AM +0000, Gupta, Pekon wrote: >> >From: Huang Shijie [mailto:b32955@xxxxxxxxxxxxx] >>> >On Tue, Dec 17, 2013 at 04:08:33AM +0000, Gupta, Pekon wrote: [...] >> >> As much base code is copied from m25p90.c, >> >> Do you mind keeping the sign-offs of the original contributors of m25p80.c >> >> at-least in patches where much code is ported ? >> >I have added the lines in the spi-nor.c: >> > >> > " Cloned most of the code from the m25p80.c" >> > >> >> This would at-least give some credit to original authors and contributors. >> >I do not change any authors information of m25p80.c. >> > >> >If it is not enough? Could you remind me what to do ? > >In case you clone most of the code from m25p80.c, you need to keep the >copyright of that file as well, and add yours on top of it. > Agree... >> > >> (1) Add sign-offs of main authors of m25p80, so that original contributors >> still remains in path of submission [1]. > >The sign-off shouldn't be added by anyone than the person himself. The >sign-off tag is generally used in the following cases as far as I know. > >1. When the patch is authored, the author A should surely add his > sign-off in the first place. > >2. If person B submits A's patch with some or without any change on the > patch, B should add his sign-off. > >3. Maintainer C should add his sign-off when he applies the patch. > >In any case, one's sign-off shouldn't be added anyone but himself. >I do not see the need to add sign-off of m25p80 authors at the current >situation. > Agree.. So I meant sign-off with permission from the original authors themselves. And Sign-offs can be multiple (but with permission of-course). OR, you can ask the original author to sign-off for you.. >> >> (2) Also, please remove following from spi-nor.c >> However, you can keep this in fsl-quadspi.c. >> +MODULE_AUTHOR("Freescale Semiconductor Inc."); >> I'm sure this was _not_ present in original m25p80.c >> (m25p80.c was started as ST's driver as per MODULE_DESCRIPTION) > >Are you talking about drivers/mtd/devices/m25p80.c? If so, I'm seeing >the following lines in the file. > >MODULE_LICENSE("GPL"); >MODULE_AUTHOR("Mike Lavender"); >MODULE_DESCRIPTION("MTD SPI driver for ST M25Pxx flash chips"); > >I think we should keep the original MODULE_LICENSE and MODULE_AUTHOR, >add a new MODULE_AUTHOR("Huang Shijie <b32955@xxxxxxxxxxxxx>") line, >and update MODULE_DESCRIPTION line properly. > As indicated in previous thread also, if the engineer's association with the company is broken then the email-id in MODULE_AUTHOR becomes invalid. Hence to keep long term tractability of the developer I suggested to use 'personal mail-id' here. MODULE_AUTHOR should have a email-id which is valid for long term, because you might need to at-least loop-in Author in longer time when there are some bug-fix or considerable code change. (This problem was also pointed out earlier in one of the emails by greg-kh, But I'm unable to trace that now). >> >> (3) +MODULE_LICENSE("GPL"); >> Also, I assume the license version should be "GPLv2" ? > >If this is from original m25p80.c, we shouldn't change it, IMO. > As I can understand from general threads on google. GPLv2 gives some additional protection to free-software companies from patent litigations of proprietary software companies. As this code is not exact replica of m25p80.c, so it should be made GPLv2 or better .. But sincerely, I do not have too much knowledge into this, So I'll let maintainers decide if they see benefit in moving to GPLv2 ? >> >> Request you please _not_ to tag generic driver frameworks with any >> specific company names, and let open-source be independent of any >> commercial company tags. > >Are you sure about that? Run git grep "redhat" on folder kernel\ and >see what you get. > Something which may have been done repeatedly in past, may not mean it is correct OR the only way to do it. :-) >> Otherwise eventually everything generic driver >> will have some or other company name associated with it. > >What's the problem of that? People are paid to do generic work, and why >shouldn't their employer's name be mentioned to give the credit. As >long as the copyright is GPL, the code can be used, modified and >distributed freely, and I do not see any problem with having company >name in there. > It's not about who is taking credit. It's about how will you track the developer if after few years you want some significant changes in the code he wrote. You would agree, it's difficult to track developers just by their company names or company IDs. It's perfectly okay, if you want to give credits of your work to anyone (whether any company or individual). But that you can mention in commit logs. All I said was using company names in Headers or MODULE_AUTHOR of *generic frameworks*. A generic framework is maintained and updated by community at large. And over course of time other people contribute more than the author. So tagging a company name there would sound like _repeatedly_ giving credit to company or yourself, even if most of the original code is changed now. Does that make sense ? So, I just suggested to keep generic framework code free from all these. However, You are free to do anything in your controller specific code. with regards, pekon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
