>From: Huang Shijie [mailto:b32955@xxxxxxxxxxxxx] >>From: Pekon Gupta [mailto:pekon@xxxxxx] [...] >> (1) Add sign-offs of main authors of m25p80, so that original contributors >> still remains in path of submission [1]. >Do you mean add the sign-offs in end of the patch 3's commit message?: > Signed-off-by: Mike Lavender <mike@xxxxxxxxxxxxxxxxx> > I think Mike's email ID is no-more valid. So you can either find out his current email-Id from other sources. OR add David's or someone else's ID which has equivalent number of contributions in m25p80.c (that you can figure out from either commit logs or git blame). >> >> (2) Also, please remove following from spi-nor.c >> However, you can keep this in fsl-quadspi.c. >> +MODULE_AUTHOR("Freescale Semiconductor Inc."); >> I'm sure this was _not_ present in original m25p80.c >> (m25p80.c was started as ST's driver as per MODULE_DESCRIPTION) >okay. > Thanks much. You can put your name instead, I don't mind that bcoz you have worked to get this framework assembled by joining different pieces. However, please use a email-id which is valid for long-term (preferably your personal ID), so that even if your association with your company ends, still there is some way to track you and keep you in loop of future patches for this framework. >> >> (3) +MODULE_LICENSE("GPL"); >> Also, I assume the license version should be "GPLv2" ? > >yes. it should be v2. > with regards, pekon -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
