On Fri, Jan 10, 2025 at 11:31:01AM -0800, Charlie Jenkins wrote:
> On Thu, Jan 09, 2025 at 03:00:59PM -0800, Charlie Jenkins wrote:
> > Ooh okay I see, the quiet commands were being ignored as-is. We could
> > add the lines to handle this to Makefile.syscalls, but I think the
> > better solution is to move the lines from Makefile.build to
> > Makefile.perf to be more generically available. Here is a patch for
> > that. I also added the comment from the kernel Makefile describing what
> > this does.
> > From 8dcec7f5d937ede3d33c687573dc2f1654ddc59e Mon Sep 17 00:00:00 2001
> > From: Charlie Jenkins <charlie@xxxxxxxxxxxx>
> > Date: Thu, 9 Jan 2025 14:36:40 -0800
> > Subject: [PATCH] perf tools: Expose quiet/verbose variables in Makefile.perf
> >
> > The variables to make builds silent/verbose live inside
> > tools/build/Makefile.build. Move those variables to the top-level
> > Makefile.perf to be generally available.
<SNIP applied patch>
> Let me know how you want to handle this, I can send this out as a
> separate patch if that's better.
I used the patch you provided above after hand editing the message
before feeding it to 'git am', added these comments:
Committer testing:
See the SYSCALL lines, now they are consistent with the other
operations in other lines:
SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_32.h
SYSTBL /tmp/build/perf-tools-next/arch/x86/include/generated/asm/syscalls_64.h
GEN /tmp/build/perf-tools-next/common-cmds.h
GEN /tmp/build/perf-tools-next/arch/arm64/include/generated/asm/sysreg-defs.h
PERF_VERSION = 6.13.rc2.g3d94bb6ed1d0
GEN perf-archive
MKDIR /tmp/build/perf-tools-next/jvmti/
MKDIR /tmp/build/perf-tools-next/jvmti/
MKDIR /tmp/build/perf-tools-next/jvmti/
MKDIR /tmp/build/perf-tools-next/jvmti/
GEN perf-iostat
CC /tmp/build/perf-tools-next/jvmti/libjvmti.o
CC /tmp/build/perf-tools-next/jvmti/jvmti_agent.o
Reported-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Signed-off-by: Charlie Jenkins <charlie@xxxxxxxxxxxx>
Tested-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Thanks,
- Arnaldo
