On Fri, Jan 10, 2025 at 09:42:52AM +0200, Robert Budai wrote: > +maintainers: > + - Nuno Sa <nuno.sa@xxxxxxxxxx> > + - Ramona Gradinariu <ramona.gradinariu@xxxxxxxxxx> > + - Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx> > + > +properties: > + compatible: > + enum: > + - adi,adis16550 > + - adi,adis16550w Where is the answer for my questions at v1? No responses on email, nothing improved in the patchset. Go back to my comments and respond to them or implement them. > + > + reg: > + maxItems: 1 > + > + spi-cpha: true > + > + spi-cpol: true > + > + spi-max-frequency: > + maximum: 15000000 > + > + vdd-supply: true > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + description: > + RESET active low pin. > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + description: If not provided, then the internal clock is used. > + > + adi,sync-mode: > + description: > + Configures the device SYNC pin. The following modes are supported > + 0 - output_sync > + 1 - direct_sync > + 2 - scaled_sync > + 3 - pulse_sync > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 1 > + maximum: 2 So what does the "3" mean? Why documenting something impossible? Anyway, use strings for these and drop "_sync" suffixes. Best regards, Krzysztof
