On Sun, Jan 12, 2025 at 5:36 PM Neal Gompa <neal@xxxxxxxxx> wrote: > > I've had my Reviewed-by tags silently ignored or deliberately stripped > because even though I've done a technical review, the maintainer does > not believe that I did. Therefore, what I am saying is that > maintainers seem to speciously decide whether an Acked-by or > Reviewed-by tag is appropriate or not *after* someone has sent it. > > This is the fundamental problem I have right now. This decision is not > the maintainer's to make, it is the submitter's. First of all, if you are referring to other cases that I may not be aware of, then I am sorry to hear that! Things like this can cause friction sometimes. Sending tags is OK, but the author/maintainer ultimately decides whether to pick them up. For Reviewed-by, I would think it is rare that it gets ignored -- after all, maintainers usually love to get that tag. If you mean the case that triggered this patch series, then (as far as I understood it), the maintainer was OK with picking your Reviewed-by and Tested-by if you sent it, but not your (bare) Acked-by. That seemed reasonable to me, because the rules are a bit unclear around the latter tag. This series tries to solve that part, so that in the future one can provide an Acked-by with a suffix in a situation like yours. Cheers, Miguel
