On Sun, Jan 12, 2025 at 10:30 AM Miguel Ojeda <ojeda@xxxxxxxxxx> wrote: > > Tags are really appreciated by maintainers in general, since it means > someone is willing to put their name on a commit, be it as a reviewer, > tester, etc. > > However, signers (i.e. submitters carrying tags from previous versions > and maintainers applying patches) may need to take or drop tags, on a > case-by-case basis, for different reasons. > > Yet this is not explicitly spelled out in the documentation, thus there > may be instances [1] where contributors may feel unwelcome. > > Thus, to clarify, state this clearly. > > Link: https://lore.kernel.org/rust-for-linux/CAEg-Je-h4NitWb2ErFGCOqt0KQfXuyKWLhpnNHCdRzZdxi018Q@xxxxxxxxxxxxxx/ [1] > Suggested-by: Dan Williams <dan.j.williams@xxxxxxxxx> > Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> > Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx> > Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx> > --- > Documentation/process/submitting-patches.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst > index 7b0ac7370cb1..6754bc15f989 100644 > --- a/Documentation/process/submitting-patches.rst > +++ b/Documentation/process/submitting-patches.rst > @@ -614,6 +614,10 @@ process nor the requirement to Cc: stable@xxxxxxxxxxxxxxx on all stable > patch candidates. For more information, please read > Documentation/process/stable-kernel-rules.rst. > > +Finally, while providing tags is welcome and typically very appreciated, please > +note that signers (i.e. submitters and maintainers) may use their discretion in > +applying offered tags. > + > .. _the_canonical_patch_format: > > The canonical patch format > -- > 2.48.0 > A tag must not be dropped without the tag submitter's authorization. Otherwise it doesn't matter what you write here, the submitter *will* feel unwelcome. It is rude and discouraging to do so without their acceptance of doing so. -- 真実はいつも一つ！/ Always, there's only one truth!
