Hi Joshua, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.13-rc6 next-20250110] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Joshua-Grisham/platform-x86-samsung-galaxybook-Add-samsung-galaxybook-driver/20250110-061059 base: linus/master patch link: https://lore.kernel.org/r/20250109220745.69977-1-josh%40joshuagrisham.com patch subject: [PATCH v5] platform/x86: samsung-galaxybook: Add samsung-galaxybook driver config: i386-randconfig-014-20250111 (https://download.01.org/0day-ci/archive/20250111/202501110304.zYo5hX2o-lkp@xxxxxxxxx/config) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250111/202501110304.zYo5hX2o-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202501110304.zYo5hX2o-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/platform/x86/samsung-galaxybook.c:759:30: error: no member named 'name' in 'struct platform_profile_handler' 759 | galaxybook->profile_handler.name = DRIVER_NAME; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ drivers/platform/x86/samsung-galaxybook.c:760:30: error: no member named 'dev' in 'struct platform_profile_handler' 760 | galaxybook->profile_handler.dev = &galaxybook->platform->dev; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ drivers/platform/x86/samsung-galaxybook.c:764:8: error: call to undeclared function 'devm_platform_profile_register'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 764 | err = devm_platform_profile_register(&galaxybook->profile_handler); | ^ drivers/platform/x86/samsung-galaxybook.c:764:8: note: did you mean 'platform_profile_register'? include/linux/platform_profile.h:37:5: note: 'platform_profile_register' declared here 37 | int platform_profile_register(struct platform_profile_handler *pprof); | ^ >> drivers/platform/x86/samsung-galaxybook.c:1057:26: error: member reference type 'struct galaxybook_fw_attr *' is a pointer; did you mean to use '->'? 1057 | sysfs_attr_init(&fw_attr.display_name); | ~~~~~~~^ | -> include/linux/sysfs.h:55:3: note: expanded from macro 'sysfs_attr_init' 55 | (attr)->key = &__key; \ | ^~~~ >> drivers/platform/x86/samsung-galaxybook.c:1057:2: error: no member named 'key' in 'struct kobj_attribute' 1057 | sysfs_attr_init(&fw_attr.display_name); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/sysfs.h:55:10: note: expanded from macro 'sysfs_attr_init' 55 | (attr)->key = &__key; \ | ~~~~~~ ^ drivers/platform/x86/samsung-galaxybook.c:1063:26: error: member reference type 'struct galaxybook_fw_attr *' is a pointer; did you mean to use '->'? 1063 | sysfs_attr_init(&fw_attr.current_value); | ~~~~~~~^ | -> include/linux/sysfs.h:55:3: note: expanded from macro 'sysfs_attr_init' 55 | (attr)->key = &__key; \ | ^~~~ drivers/platform/x86/samsung-galaxybook.c:1063:2: error: no member named 'key' in 'struct kobj_attribute' 1063 | sysfs_attr_init(&fw_attr.current_value); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/sysfs.h:55:10: note: expanded from macro 'sysfs_attr_init' 55 | (attr)->key = &__key; \ | ~~~~~~ ^ 7 errors generated. vim +1057 drivers/platform/x86/samsung-galaxybook.c 1031 1032 static int galaxybook_fw_attr_init(struct samsung_galaxybook *galaxybook, 1033 const enum galaxybook_fw_attr_id fw_attr_id, 1034 int (*get_value)(struct samsung_galaxybook *galaxybook, 1035 bool *value), 1036 int (*set_value)(struct samsung_galaxybook *galaxybook, 1037 const bool value)) 1038 { 1039 struct galaxybook_fw_attr *fw_attr; 1040 struct attribute **attrs; 1041 int err; 1042 1043 fw_attr = devm_kzalloc(&galaxybook->platform->dev, sizeof(*fw_attr), GFP_KERNEL); 1044 if (!fw_attr) 1045 return -ENOMEM; 1046 1047 attrs = devm_kcalloc(&galaxybook->platform->dev, NUM_FW_ATTR_ENUM_ATTRS + 1, 1048 sizeof(*attrs), GFP_KERNEL); 1049 if (!attrs) 1050 return -ENOMEM; 1051 1052 attrs[0] = &fw_attr_type.attr; 1053 attrs[1] = &fw_attr_default_value.attr; 1054 attrs[2] = &fw_attr_possible_values.attr; 1055 attrs[3] = &fw_attr_display_name_language_code.attr; 1056 > 1057 sysfs_attr_init(&fw_attr.display_name); 1058 fw_attr->display_name.attr.name = "display_name"; 1059 fw_attr->display_name.attr.mode = 0444; 1060 fw_attr->display_name.show = display_name_show; 1061 attrs[4] = &fw_attr->display_name.attr; 1062 1063 sysfs_attr_init(&fw_attr.current_value); 1064 fw_attr->current_value.attr.name = "current_value"; 1065 fw_attr->current_value.attr.mode = 0644; 1066 fw_attr->current_value.show = current_value_show; 1067 fw_attr->current_value.store = current_value_store; 1068 attrs[5] = &fw_attr->current_value.attr; 1069 1070 attrs[6] = NULL; 1071 1072 fw_attr->galaxybook = galaxybook; 1073 fw_attr->fw_attr_id = fw_attr_id; 1074 fw_attr->attr_group.name = galaxybook_fw_attr_name[fw_attr_id]; 1075 fw_attr->attr_group.attrs = attrs; 1076 fw_attr->get_value = get_value; 1077 fw_attr->set_value = set_value; 1078 1079 err = sysfs_create_group(&galaxybook->fw_attrs_kset->kobj, &fw_attr->attr_group); 1080 if (err) 1081 return err; 1082 1083 return devm_add_action_or_reset(&galaxybook->platform->dev, 1084 galaxybook_fw_attr_remove, fw_attr); 1085 } 1086 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
