On 1/9/2025 5:15 PM, Krzysztof Kozlowski wrote:
On Wed, Jan 08, 2025 at 09:47:08PM +0800, Luo Jie wrote:
+ required:
+ - clocks
+ - clock-names
+ - resets
+ - interrupts
+ - interrupt-names
+
+ ethernet-ports:
This device really looks like DSA or other ethernet switch, so I would
really expect proper $ref in top-level.
Sure, agree that the PPE is better modeled as an Ethernet switch. I will
add and use the $ref ethernet-switch.yaml in the top-level.
+ type: object
+ additionalProperties: false
+ properties:
+ '#address-cells':
+ const: 1
+ '#size-cells':
+ const: 0
+
+ patternProperties:
+ "^port@[1-6]$":
+ type: object
+ $ref: ethernet-controller.yaml#
Everything here is duplicating DSA or ethernet-switch, so that's
surprising.
I will remove the current 'ethernet-ports' node and the "$ref: ethernet-
controller.yaml#" from the port node. As the top-level $ref, will use
ethernet-switch.yaml instead.
The PPE Ethernet port node requires the additional DT properties clocks
and resets, which will be added into the switch port node. Thanks.
+ unevaluatedProperties: false
+ description:
+ PPE port that includes the MAC used to connect the external
+ switch or PHY via the PCS.
Best regards,
Krzysztof
