On 10/01/2025 09:15, Leo Yang wrote: > Add TI INA233 Current and Power Monitor bindings. > > Signed-off-by: Leo Yang <Leo-Yang@xxxxxxxxxxxx> > --- > .../devicetree/bindings/hwmon/ti,ina2xx.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > index 05a9cb36cd82..9759c69b904b 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml > @@ -27,6 +27,7 @@ properties: > - ti,ina226 > - ti,ina230 > - ti,ina231 > + - ti,ina233 > - ti,ina237 > - ti,ina238 > - ti,ina260 > @@ -75,6 +76,22 @@ properties: > the alert polarity to active-high. > $ref: /schemas/types.yaml#/definitions/flag > > + ti,current-lsb: > + description: > + This value depends on the maximum current that can be expected to be Then use microamp unit suffix and drop the ref and all these calculations. > + measured by ina233 in your circuit, divide Maximum Expected Current > + by 2^15 and express it in microamps. > + > + This value will be used to calculate the current/power coefficient for > + the pmbus and to calibrate the IC. > + > + For device INA233. And not valid for other devices? Then in allOf:if:then: you should disallow it for others and drop redundant descriptions (don't repeat the schema). Best regards, Krzysztof