Re: [PATCH v2 3/3] tun: Set num_buffers for virtio 1.0

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>
Subject: Re: [PATCH v2 3/3] tun: Set num_buffers for virtio 1.0
From: Jason Wang <jasowang@xxxxxxxxxx>
Date: Fri, 10 Jan 2025 11:27:13 +0800
Cc: Jonathan Corbet <corbet@xxxxxxx>, Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, Yuri Benditovich <yuri.benditovich@xxxxxxxxxx>, Andrew Melnychenko <andrew@xxxxxxxxxx>, Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>, gur.stavi@xxxxxxxxxx, devel@xxxxxxxxxx
In-reply-to: <20250109-tun-v2-3-388d7d5a287a@daynix.com>
References: <20250109-tun-v2-0-388d7d5a287a@daynix.com> <20250109-tun-v2-3-388d7d5a287a@daynix.com>

On Thu, Jan 9, 2025 at 2:59 PM Akihiko Odaki <akihiko.odaki@xxxxxxxxxx> wrote:
>
> The specification says the device MUST set num_buffers to 1 if
> VIRTIO_NET_F_MRG_RXBUF has not been negotiated.

Have we agreed on how to fix the spec or not?

As I replied in the spec patch, if we just remove this "MUST", it
looks like we are all fine?

Thanks

Follow-Ups:
- Re: [PATCH v2 3/3] tun: Set num_buffers for virtio 1.0
  - From: Michael S. Tsirkin
- Re: [PATCH v2 3/3] tun: Set num_buffers for virtio 1.0
  - From: Akihiko Odaki

References:
- [PATCH v2 0/3] tun: Unify vnet implementation and fill full vnet header
  - From: Akihiko Odaki
- [PATCH v2 3/3] tun: Set num_buffers for virtio 1.0
  - From: Akihiko Odaki

Prev by Date: Re: [PATCH v2 1/3] tun: Unify vnet implementation
Next by Date: Re: [PATCH v2 2/3] tun: Pad virtio header with zero
Previous by thread: Re: [PATCH v2 3/3] tun: Set num_buffers for virtio 1.0
Next by thread: Re: [PATCH v2 3/3] tun: Set num_buffers for virtio 1.0
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]