On Thu, Dec 26, 2024 at 12:27:34PM +0100, Antheas Kapenekakis wrote: > With the X1 (AMD), OneXPlayer added a charge limit and charge bypass to > their devices. Charge limit allows for choosing an arbitrary battery > charge setpoint in percentages. Charge bypass allows to instruct the > device to stop charging either when its on or always. > > This feature was then extended for the F1Pro as well. OneXPlayer also > released BIOS updates for the X1 Mini, X1 (Intel), and F1 devices that > add support for this feature. Therefore, enable it for all F1 and > X1 devices. > > Add both of these under the standard sysfs battery endpoints for them, > by looking for the battery. OneXPlayer devices have a single battery. > This exceeds the scope of a hardware monitoring device, and even more so with the subsequent addition of LED support. I would suggest to move the code to drivers/platform/x86/, where multi-function drivers in a single file are permitted. Thanks, Guenter