Re: [PATCH net-next v7 10/10] selftest: net-drv: hds: add test for HDS feature

[Taehee Yoo <ap420073@xxxxxxxxx>]

On Tue, Jan 7, 2025 at 12:01 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>

Hi Jakub,
Thanks a lot for the review!

> On Fri,  3 Jan 2025 15:03:25 +0000 Taehee Yoo wrote:
> > +    try:
> > +        netnl.rings_set({'header': {'dev-index': cfg.ifindex}, 'hds-thresh': hds_gt})
> > +    except NlError as e:
> > +        if e.error == errno.EOPNOTSUPP:
> > +            raise KsftSkipEx("ring-set not supported by the device")
> > +        ksft_eq(e.error, errno.EINVAL)
> > +    else:
> > +        raise KsftFailEx("exceeded hds-thresh should be failed")
>
> Nice work on the tests! FWIW you could use ksft_raises(NlError) here,
> but this works too. You can leave it as is if you prefer.

Thanks for the suggestion, I will change it after tests!

Thanks a lot,
Taehee Yoo