Re: [PATCH] git-disambiguate: disambiguate shorthand git ids

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sasha,

On Fri, Dec 27, 2024 at 5:19 PM Sasha Levin <sashal@xxxxxxxxxx> wrote:
> No, it's not a problem. In my mind, I figured we could use shorter
> hashes in mail message to make it easier to communicate.
>
> It doesn't have to be formal, but for example if we exchange mails about
> an issue, and I end up referring to '1d1a ("arm64/sme: ...")' it both
> makes the mail more readable, but still someone who doesn't have context
> can still easily get to the commit I was referring to.

Is that 1d1a commit something in your local tree? I don't seem to have it.

A few other comments:
  1. Please add support for --help. It took me a while to find out I
     need to call the script without parameters to get the help.
  2. The passed commit-subject needs to be the full commit subject.
     It would be nice to support abbreviations, too.

BTW, I am a heavy user of looking up commits (recent and old ;-)
My .vimrc has:

    noremap ;gs "zyiw:exe "new \| setlocal buftype=nofile
bufhidden=hide noswapfile syntax=git \| 0r ! git show ".@z."" \|
:0<CR><CR>

So I can move the cursor to a git commit ID, and type ";gs" to open
the commit in a throw-away split window.
Adding full support for commit-subjects may be challenging, especially
if they are split across multiple lines (i.e. not Fixes: tags, but
mentioned in the description).

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds





[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux