Hi Guenter, Right now, OneXPlayer features a singular EC with a handful of features. Where with this patch series we essentially have parity with windows, apart from a VRAM feature which I will have to ask but I suspect is WMI. It currently concerns a singular component (the EC) and the functionality such as turbo button affects the hwmon component (i.e., if the turbo button is not engaged, the fan control functionality does not work). As such it cannot be made into separate drivers. I think, and I suspect you will agree, that the scope of the driver is _correct_ but the place is not correct. Therefore, can you suggest a reasonable path forward that is sparing to this patch series? Should I add an eleventh patch that grafts this driver to platform-x86? If appropriate, you can cc the x86 mailing list on your next email. Best, Antheas On Thu, 26 Dec 2024 at 22:16, Derek J. Clark <derekjohn.clark@xxxxxxxxx> wrote: > > > > On December 26, 2024 1:08:02 PM PST, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > >On Thu, Dec 26, 2024 at 12:27:30PM +0100, Antheas Kapenekakis wrote: > >> This three part series updates the oxpsensors module to bring it in line > >> with its Windows OneXPlayer counterpart. First, it adds support for all > >> 2024 OneXPlayer handhelds and their special variants. > >> > >> Then, it adds the new charge limiting and bypass features that were first > >> introduced in the X1 and retrofit to older OneXFly variants and for > >> controlling the turbo led found in the X1 models. For Bypass, it adds a new > >> bypass variant BypassS0 that is only active while the device is in the S0 > >> state. > >> > > > >This is a hardware monitoring driver. It is not a charge controller driver, > >and it is not a LED controller driver. If such control is wanted/needed for > >this system, it should be implemented either as mfd device with client drivers, > >or the entire driver should be moved to platform drivers if there is a desire > >to keep it as single driver. > > > >Guenter > > I think moving this to x86 platform makes a lot of sense to ensure two separate drivers can't do async writes to the EC. We probably should have done that when adding the turbo button toggle anyway. I'll coordinate that effort with Tobias and Antheas directly before moving forward. > > Thanks Guenter, > - Derek
