On Tue, Dec 24, 2024 at 11:00:38AM +0800, Gordon - wrote: > On Tue, Dec 24, 2024 at 1:11 AM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote: > > > > On 12/23/24 02:04, Gordon Ou wrote: > > > Corrects byte offsets for OP_REP_IMPORT. > > > > Add more information on why this change is needed. > > > > The change is needed to correct the mistaken byte offset of the field > bDeviceClass in OP_REP_IMPORT documentation. The previous field bcdDevice > has length 2 and the offset for bDeviceClass should be 0x138 + 2 = 0x13A > instead of 0x139. Offsets for subsequent fields are also affected and fixed > in this patch. Great, please include that in the changelog text when you resend this. thanks, greg k-h