On Thu, Dec 19, 2024 at 11:49 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Wed, 18 Dec 2024 14:45:30 +0000 Taehee Yoo wrote: > > drivers/net/netdevsim/ethtool.c | 15 ++++++++++++++- > > drivers/net/netdevsim/netdevsim.h | 4 ++++ > > netdevsim patches must come with a selftest that uses them :) > We support bash, C and Python tests. Look inside > tools/testing/selftests/drivers/net/ > These tests could serve as examples: stats.py, hw/ncdevmem.c > > TBH it doesn't look like netdevsim _actually_ supports HDS, > as in forwarded packets will not be split with the current > code, or linearized. You'd need to modify nsim_start_xmit() > to either linearize the packet or not based on *peer's* HDS > settings. Ah, Sorry for the sloppy change. I will write a selftest. Also, I will modify nsim_start_xmit() to support HDS. The example would be very helpful to me. Thank you so much! Taehee Yoo.