Re: [PATCH net-next v6 5/9] bnxt_en: add support for hds-thresh ethtool command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jakub Kicinski <kuba@xxxxxxxxxx>
Subject: Re: [PATCH net-next v6 5/9] bnxt_en: add support for hds-thresh ethtool command
From: Taehee Yoo <ap420073@xxxxxxxxx>
Date: Thu, 19 Dec 2024 23:12:15 +0900
Cc: davem@xxxxxxxxxxxxx, pabeni@xxxxxxxxxx, edumazet@xxxxxxxxxx, almasrymina@xxxxxxxxxx, donald.hunter@xxxxxxxxx, corbet@xxxxxxx, michael.chan@xxxxxxxxxxxx, andrew+netdev@xxxxxxx, hawk@xxxxxxxxxx, ilias.apalodimas@xxxxxxxxxx, ast@xxxxxxxxxx, daniel@xxxxxxxxxxxxx, john.fastabend@xxxxxxxxx, dw@xxxxxxxxxxx, sdf@xxxxxxxxxxx, asml.silence@xxxxxxxxx, brett.creeley@xxxxxxx, linux-doc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, kory.maincent@xxxxxxxxxxx, maxime.chevallier@xxxxxxxxxxx, danieller@xxxxxxxxxx, hengqi@xxxxxxxxxxxxxxxxx, ecree.xilinx@xxxxxxxxx, przemyslaw.kitszel@xxxxxxxxx, hkallweit1@xxxxxxxxx, ahmed.zaki@xxxxxxxxx, rrameshbabu@xxxxxxxxxx, idosch@xxxxxxxxxx, jiri@xxxxxxxxxxx, bigeasy@xxxxxxxxxxxxx, lorenzo@xxxxxxxxxx, jdamato@xxxxxxxxxx, aleksander.lobakin@xxxxxxxxx, kaiyuanz@xxxxxxxxxx, willemb@xxxxxxxxxx, daniel.zahka@xxxxxxxxx, Andy Gospodarek <gospo@xxxxxxxxxxxx>
In-reply-to: <20241218184000.54831119@kernel.org>
References: <20241218144530.2963326-1-ap420073@gmail.com> <20241218144530.2963326-6-ap420073@gmail.com> <20241218184000.54831119@kernel.org>

On Thu, Dec 19, 2024 at 11:40 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> On Wed, 18 Dec 2024 14:45:26 +0000 Taehee Yoo wrote:
> > +#define BNXT_HDS_THRESHOLD_MAX       1023
> > +     u16                     hds_threshold;
>
> How about we add hds_threshold to struct ethtool_netdev_state ?
> That way in patch 6 we don't have to call the driver to get it.

I agree, it looks much better! I will change it.

Thanks a lot!
Taehee Yoo

References:
- [PATCH net-next v6 0/9] bnxt_en: implement tcp-data-split and thresh option
  - From: Taehee Yoo
- [PATCH net-next v6 5/9] bnxt_en: add support for hds-thresh ethtool command
  - From: Taehee Yoo
- Re: [PATCH net-next v6 5/9] bnxt_en: add support for hds-thresh ethtool command
  - From: Jakub Kicinski

Prev by Date: Re: [PATCH net-next v6 4/9] net: ethtool: add support for configuring hds-thresh
Next by Date: Re: [PATCH net-next v6 8/9] net: disallow setup single buffer XDP when tcp-data-split is enabled.
Previous by thread: Re: [PATCH net-next v6 5/9] bnxt_en: add support for hds-thresh ethtool command
Next by thread: [PATCH net-next v6 6/9] net: devmem: add ring parameter filtering
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]