Re: [RFC net-next v02 1/3] net: hinic3: module initialization and tx/rx logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > +static int hinic3_sw_init(struct net_device *netdev)
> > > +{
> > > +	struct hinic3_nic_dev *nic_dev = netdev_priv(netdev);
> > > +	struct hinic3_hwdev *hwdev = nic_dev->hwdev;
> > > +	int err;
> > > +
> > > +	nic_dev->q_params.sq_depth = HINIC3_SQ_DEPTH;
> > > +	nic_dev->q_params.rq_depth = HINIC3_RQ_DEPTH;
> > > +
> > > +	hinic3_try_to_enable_rss(netdev);
> > > +
> > > +	eth_hw_addr_random(netdev);
> >
> > Is using a random MAC just a temporary thing until more code is added
> > to access an OTP?
> >
> 
> No, using a random MAC is not a temporary solution.
> This device is designed for cloud environments. VFs are expected to be
> used by VMs that may migrate from device to device. Therefore the HW does
> not provide a MAC address to VFs, but rather the VF driver selects a
> random MAC address and configures it into the (current) device.

If you look at MAC drivers in general, this is unusual. So it would be
good to add a comment why this unusual behaviour is used.

	Andrew




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux