On Wed, 18 Dec 2024 14:45:22 +0000 Taehee Yoo wrote: > + if (netif_running(dev)) { > + bnxt_close_nic(bp, false, false); > + bp->rx_copybreak = rx_copybreak; > + bnxt_set_ring_params(bp); > + bnxt_open_nic(bp, false, false); We really shouldn't allow this any more, we've been rejecting patches which try to accept reconfiguration requests by taking the entire NIC down, without any solid recovery if memory allocation fails. Let's return -EBUSY if interface is running.