On 2024-12-17 15:23:22+0100, Hans de Goede wrote:
> On 16-Dec-24 5:46 PM, Thomas Weißschuh wrote:
[..]
> >> +Keyboard hotkey actions (i8042 filter)
> >> +======================================
> >> +
> >> +Controlled by parameter: ``i8042_filter``
> >> +
> >> +The i8042 filter will swallow the keyboard events for the Fn+F9 hotkey (Multi-
> >> +level keyboard backlight toggle) and Fn+F10 hotkey (Allow/block recording
> >> +toggle) and instead execute their actions within the driver itself.
> >> +
> >> +Fn+F9 will cycle through the brightness levels of the keyboard backlight. A
> >> +notification will be sent using ``led_classdev_notify_brightness_hw_changed``
> >> +so that the userspace can be aware of the change. This mimics the behavior of
> >> +other existing devices where the brightness level is cycled internally by the
> >> +embedded controller and then reported via a notification.
> >> +
> >> +Fn+F10 will toggle the value of the "Allow recording" setting.
> >
> > Personally I'm not a big fan to implement policy this way in the kernel.
> > But others may disagree.
>
> The keyboard backlight cycling ws already discussed and handling this in
> the driver is ok.
Ack.
[..]
> >> +static struct platform_driver galaxybook_platform_driver = {
> >
> > Could this be a 'struct acpi_driver'?
>
> The use of acpi_driver is deprecated. AFAIK the plan it to
> move the remaining ones to platform-drivers and eventually
> remove the whole ACPI bus concept turning ACPI companion
> nodes into "normal" fwnodes like the current software and
> openfirmware fwnodes.
Thanks for this explanation, I was not aware.
It explains the comment from Rafael in [0].
[0] https://lore.kernel.org/lkml/CAJZ5v0g0B8UFqYza88ahMfC-1_FzzizeS6QN=Qtt7vGv9+TK1w@xxxxxxxxxxxxxx/
