On Mon, Dec 16, 2024, 5:41 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Mon, 16 Dec 2024 10:58:10 -0800 Li Li wrote: > > > not: There are several places where you have "netlink_nl" which seems > > > kind of redundant to me. wdyt? IMO you should drop the "nl" in all of > > > these cases. > > > > > > > These are automatically generated from the yaml file. So let's just > > keep them as is. > > But it's a good suggestion to the owner of yaml parser. > > I think the unusual naming comes from fact that you call your netlink > family binder_netlink. It's sort of like adding the word sysfs to the > name of a sysfs file. I mean the user visible name, not code > references... > > s/binder_netlink/binder/ will clean this up.. I did consider that but unfortunately that would result in a conflicting binder.h in uapi header. Probably "binder_report" or "bindererr"?
