Hi Jakub, On Tue, Dec 10, 2024 at 06:37:04AM -0800, Jakub Kicinski wrote: > > I certainly can't help but write the "returns" statement in natural > > English, rather than kernel-doc "Returns:" style as can be seen from > > my recent patches that have been merged. "Returns" without a colon is > > just way more natural when writing documentation. > > > > IMHO, kernel-doc has made a wrong decision by requiring the colon. > > For the patch under consideration, however, I think _some_ attempt > to make fully documenting callbacks inline possible needs to be made :( Please rephrase, I do not understand. Should I resend this patch with corrected "Return:" description, or continue with inlined comments withing the struct and drop this patch? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
