Den sön 15 dec. 2024 kl 21:02 skrev Armin Wolf <W_Armin@xxxxxx>: > > The dell-wmi-ddv driver does manage his battery extension without any global variables. > Could it be that you confused it with another Dell driver? > Yes I think I was looking at another one, but have reviewed dell-wmi-ddv and it was very similar to what I had done. I will adjust samsung-galaxybook just a bit more so it is closer to what is already in dell-wmi-ddv (e.g. use a normal device_attribute without the extended var and use that with container_of to fetch my private data). Thank you! > Please submit this v2 patch as its own separate patch as described in > https://docs.kernel.org/process/submitting-patches.html ("The canonical patch format"). > > If you use "git send-email", you can use the -v2 option to automatically adjust the patch > header. > > You can describe the changes you made like this: > > <commit message> > ... > Signed-off-by: Author <author@mail> > --- > V1 -> V2: > - <description of changes> > - ... > > path/to/file | 5+++-- > ... > > Thanks, > Armin Wolf > Thank you both Armin and Guenter for highlighting this! I did in fact use "git send-email" but did not check the contents of the patch file (other than running the check script and resolving various issues it reported) to ensure it looked ok -- lesson learned and I will submit a v3 (including above-mentioned changes) of the patch shortly or possibly tomorrow :) Cheers! Best regards, Joshua
