Den mån 9 dec. 2024 kl 17:58 skrev Guenter Roeck <linux@xxxxxxxxxxxx>: > > > + if (channel < galaxybook_ptr->fans_count && attr == hwmon_fan_input) { > Why is this check necesary ? The is_visible function should have masked it out. > > > [...] > Same as above. > > Guenter > > > [...] Hi Guenter, now I have removed all of this from the v2 patch for this driver and instead will pursue support for these fan devices directly within ACPI instead! Thank you for taking a look! Best, Joshua