Re: [PATCH v1 4/6] docs: 6.Followthrough.rst: tags to use in regressions fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thorsten Leemhuis <linux@xxxxxxxxxxxxx> writes:

> Add a few notes on the appropriate tags to be used in changes that fix
> regressions.
>
> This removes equivalent paragraphs from a section in
> Documentation/process/handling-regressions.rst, which will become mostly
> obsolete through this and follow-up changes.
>
> Signed-off-by: Thorsten Leemhuis <linux@xxxxxxxxxxxxx>
> ---
>
> Note:
>
> * Not sure if the "add a second Fixes: tag for the change that exposed
>   an earlier problem" is appropriate, but it results in the most
>   reliable solution without much overhead.
>
> * On a brief look it might seem like this changes the "participation in
>   stable is optional for mainline developers" approach. But that is not
>   the case, as the point is just kindly asking developers to take care
>   of stable inclusion.
> ---
>  Documentation/process/6.Followthrough.rst      | 16 ++++++++++++++++
>  Documentation/process/handling-regressions.rst |  7 -------
>  2 files changed, 16 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/process/6.Followthrough.rst b/Documentation/process/6.Followthrough.rst
> index 763a80d21240f0..2ba16a71aba9b4 100644
> --- a/Documentation/process/6.Followthrough.rst
> +++ b/Documentation/process/6.Followthrough.rst
> @@ -234,6 +234,22 @@ On procedure:
>     requests again should ideally come directly from maintainers or happen in
>     accordance with them.
>  
> +On tags in the patch description of regressions fixes:

"regression" (no "s")

> + - Include the tags Documentation/process/5.Posting.rst mentions for
> +   regressions; this usually means a "Reported-by:" tag followed by "Link:" or
> +   "Closes:" tag pointing to the report as well as a "Fixes:" tag; if it's a
> +   regression a later change exposed, add a "Fixes:" tag for that one, too.
> +
> + - Did the culprit make it into a proper mainline release during the past
> +   twelve months? Or is it a recent mainline commit backported to stable or
> +   longterm releases in the past few weeks? Then you are kindly asked to ensure
> +   stable inclusion as described by Documentation/process/stable-kernel-rules.rst.
> +   Usually you want to realized thos by adding a "Cc: stable@xxxxxxxxxxxxxxx" to

Something went a bit astray in that sentence.  "you want to do this" ?

> +   the patch description.  Note, a "Fixes:" tag alone does not guarantee a
> +   backport, as the stable team does not pick up all such changes and might
> +   silently drop them in case trouble arises.

In the past we have had subsystem maintainers who didn't want people to
put CC: stable tags into their own patches; not sure if that's still the case?

Thanks,

jon




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux