Re: [PATCH v4 08/18] dma-mapping: Implement link/unlink ranges API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Leon Romanovsky <leon@xxxxxxxxxx>
Subject: Re: [PATCH v4 08/18] dma-mapping: Implement link/unlink ranges API
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 12 Dec 2024 09:43:32 +0100
Cc: Jens Axboe <axboe@xxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Robin Murphy <robin.murphy@xxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Sagi Grimberg <sagi@xxxxxxxxxxx>, Leon Romanovsky <leonro@xxxxxxxxxx>, Keith Busch <kbusch@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, Yishai Hadas <yishaih@xxxxxxxxxx>, Shameer Kolothum <shameerali.kolothum.thodi@xxxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Alex Williamson <alex.williamson@xxxxxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Jérôme Glisse <jglisse@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
In-reply-to: <50de680233f2947594471d30976565c209bf7864.1733398913.git.leon@kernel.org>
References: <cover.1733398913.git.leon@kernel.org> <50de680233f2947594471d30976565c209bf7864.1733398913.git.leon@kernel.org>
User-agent: Mutt/1.5.17 (2007-11-01)

> +static inline int dma_iova_sync(struct device *dev, struct dma_iova_state *state,

Please avoid the overly long line here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH v4 00/18] Provide a new two step DMA mapping API
  - From: Leon Romanovsky
- [PATCH v4 08/18] dma-mapping: Implement link/unlink ranges API
  - From: Leon Romanovsky

Prev by Date: Re: [PATCH v4 06/18] dma: Provide an interface to allow allocate IOVA
Next by Date: Re: [PATCH v4 05/18] dma-mapping: Add check if IOVA can be used
Previous by thread: [PATCH v4 08/18] dma-mapping: Implement link/unlink ranges API
Next by thread: [PATCH v4 05/18] dma-mapping: Add check if IOVA can be used
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]