Re: [PATCH net-next v3 3/5] page_pool: Set `dma_sync` to false for devmem memory provider

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Mina Almasry <almasrymina@xxxxxxxxxx>
Subject: Re: [PATCH net-next v3 3/5] page_pool: Set `dma_sync` to false for devmem memory provider
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Tue, 10 Dec 2024 19:44:11 -0800
Cc: netdev@xxxxxxxxxxxxxxx, Pavel Begunkov <asml.silence@xxxxxxxxx>, Kaiyuan Zhang <kaiyuanz@xxxxxxxxxx>, Willem de Bruijn <willemb@xxxxxxxxxx>, Samiullah Khawaja <skhawaja@xxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, Ilias Apalodimas <ilias.apalodimas@xxxxxxxxxx>
In-reply-to: <20241209172308.1212819-4-almasrymina@google.com>
References: <20241209172308.1212819-1-almasrymina@google.com> <20241209172308.1212819-4-almasrymina@google.com>

On Mon,  9 Dec 2024 17:23:06 +0000 Mina Almasry wrote:
> +	/* dma-buf dma addresses should not be used with

Sounds a bit scary, maybe let's say:
                                 vvvvvvvvvvvvvvv
	/* dma-buf DMA addresses do not need and should not be used with

? up to you.

References:
- [PATCH net-next v3 0/5] devmem TCP fixes
  - From: Mina Almasry
- [PATCH net-next v3 3/5] page_pool: Set `dma_sync` to false for devmem memory provider
  - From: Mina Almasry

Prev by Date: [PATCH v8 21/21] tools/testing/cxl: Add DC Regions to mock mem data
Next by Date: Re: [PATCH net-next v3 4/5] page_pool: disable sync for cpu for dmabuf memory provider
Previous by thread: [PATCH net-next v3 3/5] page_pool: Set `dma_sync` to false for devmem memory provider
Next by thread: [PATCH net-next v3 5/5] net: Document memory provider driver support
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]