>* linux@xxxxxxxxxxx (linux@xxxxxxxxxxx) wrote: >> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx> >> >> devm_devfreq_register_notifier() and devm_devfreq_unregister_notifier() >> have been unused since 2019's >> commit 0ef7c7cce43f ("PM / devfreq: passive: Use non-devm notifiers") >> >> Remove them, and the helpers they used. >> >> Note, devm_devfreq_register_notifier() is still used as an example >> in Documentation/doc-guide/contributing.rst but that's just >> an example of an old doc bug rather than anything about the function >> itself. >> >> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx> > >Ping. > >Thanks, > >Dave When I search github, it appears that vendors are using this API. NVIDIA: https://github.com/NX-Development/android_kernel_nvidia_nvidia/blob/c9ade3b5e32a12b8cf6f33a632dc39209194e4e8/drivers/devfreq/governor_wmark_active.c#L624 Samsung: https://github.com/Vaz15k/android_kernel_samsung_a54x/blob/8ac517c37c606746213064857dc240e99eba80d2/drivers/soc/samsung/exynos-llcgov.c#L107 Realtek: https://github.com/BPI-SINOVOIP/BPI-M4-bsp/blob/25f5b88ec4ba34029f964693dc34028b26e6c67c/linux-rtk/drivers/devfreq/realtek/governor_rtk_ltl.c#L114 Please don't remove ABIs used by vendors even if they didn't upstream their drivers. Cheers, MyungJoo.