On Thu, Dec 05, 2024 at 12:02:19PM +0000, Russell King (Oracle) wrote: > On Tue, Dec 03, 2024 at 08:56:17AM +0100, Oleksij Rempel wrote: > > Convert the PHY flag definitions to use the BIT() macro instead of > > hexadecimal values. This improves readability and maintainability. > > Maybe only readability. One can argue that changing them introduces the > possibility of conflicts when porting patches which adds maintenance > burden. Thinking a bit more about this, we can do much better to improve readability. The question that stands out right now is "but what are these flags used for?" and their definition doesn't make any hint. The PHY_* constants are for struct phy_driver.flags, and I think this needs to be documented. I think that's a much more important detail here that would massively improve readability way beyond simply changing them to be defined in terms of BIT(). -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
