On Wed, 04 Dec 2024, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> wrote:
> Since commit cdd30ebb1b9f ("module: Convert symbol namespace to string
> literal") the namespace has to be a string. Fix accordingly.
Interesting. Using preprocessor symbols inherently restricted the
namespace syntax to that of C identifiers.
Is it now okay to use any syntax for the namespaces from now on? Should
the document have some recommendations for naming namespaces?
BR,
Jani.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>
> ---
> Documentation/core-api/symbol-namespaces.rst | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/core-api/symbol-namespaces.rst b/Documentation/core-api/symbol-namespaces.rst
> index 27a9cccc792c..a08a3448cbad 100644
> --- a/Documentation/core-api/symbol-namespaces.rst
> +++ b/Documentation/core-api/symbol-namespaces.rst
> @@ -41,9 +41,8 @@ entries.
> In addition to the macros EXPORT_SYMBOL() and EXPORT_SYMBOL_GPL(), that allow
> exporting of kernel symbols to the kernel symbol table, variants of these are
> available to export symbols into a certain namespace: EXPORT_SYMBOL_NS() and
> -EXPORT_SYMBOL_NS_GPL(). They take one additional argument: the namespace.
> -Please note that due to macro expansion that argument needs to be a
> -preprocessor symbol. E.g. to export the symbol ``usb_stor_suspend`` into the
> +EXPORT_SYMBOL_NS_GPL(). They take one additional argument: the namespace as a
> +C-string. E.g. to export the symbol ``usb_stor_suspend`` into the
> namespace ``USB_STORAGE``, use::
>
> EXPORT_SYMBOL_NS(usb_stor_suspend, "USB_STORAGE");
--
Jani Nikula, Intel
