Hi Mauro, On Tue, Dec 03, 2024 at 09:26:13AM +0100, Mauro Carvalho Chehab wrote: > > > +is also based on a trust relationship between the rest of the committers, > > > > s/also// > > s/between the rest of/among/ > > > > I wonder if we should add here some expectation on being reachable on > > #linux-media. > > I'll add it at the note about linuxtv.org: > > These commit rights are granted with expectation of responsibility: > committers are people who care about the Linux Kernel as a whole and > about the Linux media subsystem and want to advance its development. It > is also based on a trust relationship among other committers, maintainers > and the Linux Media community[1]. > > ... > > > [1] The Linux Media Community, also called LinuxTV Community, has its primary > site at https://linuxtv.org. > > Media committers and developers are reachable via the #linux-media > IRC channel at OFTC. Looks good, thanks! > > > > +maintainers and the Linux Media community[1]. > > > + > > > +As such, a media committer is not just someone who is capable of creating > > > +code, but someone who has demonstrated their ability to collaborate > > > +with the team, get the most knowledgeable people to review code, > > > +contribute high-quality code, and follow through to fix issues (in code > > > +or tests). > > > + > > > +.. Note:: > > > + > > > + 1. If a patch introduces a regression, then it is the media committer's > > > + responsibility to correct that as soon as possible. Typically the > > > + patch is either reverted, or an additional patch is committed that > > > + fixes the regression; > > > > s/that fixes/to fix/ > > Ok. > > > > > > + 2. if patches are fixing bugs against already released Kernels, including > > > + the reverts above mentioned, the media committer shall add the needed > > > + tags. Please see :ref:`Media development workflow` for more details. > > > > Does this reference work? > > Yes. Tested on Sphinx 6.2.0. > > > > +[1] The Linux Media community, also called LinuxTV community, has its primary > > > + site at https://linuxtv.org. > > > + > > > +Becoming a media committer > > > +-------------------------- > > > + > > > +The most important aspect of volunteering to be a committer is that you have > > > +demonstrated the ability to give good code reviews. So we are looking for > > > > I wonder if we should add some kind of an expectation of demonstrating > > common sense? :-) > > Could you propose some text for that? How about: The most important aspects of volunteering to be a committer are that you have demonstrated the ability to give good code reviews, interacting with others in the community as well as common sense. These are what we're looking for when we're judging whether you'd be a good Media committer. > > > > +whether or not we think you will be good at doing that. > > > + > > > +As such, potential committers must earn enough credibility and trust from the > > > +LinuxTV community. To do that, developers shall be familiar with the open > > > +source model and have been active in the Linux Kernel community for some time, > > > +and, in particular, in the media subsystem. > > > + > > > +So, in addition to actually making the code changes, you are basically > > > +demonstrating your: > > > + > > > +- commitment to the project; > > > +- ability to collaborate with the team and communicate well; > > > +- understand of how upstream and the LinuxTV community work > > > + (policies, processes for testing, code review, ...) > > > +- reasonable knowledge about: > > > + > > > + - the Kernel development process: > > > + Documentation/process/index.rst > > > > :ref:`the Kernel development process <process_index>` > > No need. a Sphinx converts all *.rst into references automatically. > > Better to use RST files at the text, as makes easier for people > reading the text file directly. Ack. > > > > + > > > + - the Media development profile: > > > + Documentation/driver-api/media/maintainer-entry-profile.rst > > > > Could you add a label to the title and refer to it directly? > > Same as above. > > > > + > > > +- understanding of the projects' code base and coding style; > > > +- ability to provide feedback to the patch authors; > > > +- ability to judge when a patch might be ready for review and to submit; > > > +- ability to write good code (last but certainly not least). > > > + > > > +Developers that intend to become committers are encouraged to participate > > > > s/intend/yearn/ > > Heh, I had to go to the dictionary to seek for "yearn" meaning ;-) > > Let's use a simpler language, as most developers are not native-English > speakers. I did: > > s/intend/desire/ > > which is a synonym. Works for me. -- Kind regards, Sakari Ailus
