On Mon, Dec 02, 2024 at 04:00:47PM +0100, Dragan Simic wrote: > On 2024-11-09 04:10, Dragan Simic wrote: > > On 2024-11-08 20:12, Dan Williams wrote: > > > Dragan Simic wrote: > > > > I'm fully aware that we may be reluctant to supporting > > > > additional tags, > > > > because we may then end up with a whole bunch of strange tags > > > > that might > > > > be a bit hard to understand and use properly, but I think that adding > > > > Helped-by to the supported tag list may actually be a good thing > > > > to do. > > > > As described above, Helped-by fits very well between the Suggested-by > > > > tag and the Co-developed-by + Signed-off-by pair of tags, and I think > > > > that providing the right level of attribution may be beneficial. > > > > > > Patch attribution is separate from giving thanks. I would much rather > > > someone take the time to say "Thanks" in the changelog with some > > > supporting text rather than boil down all the myriad ways to be > > > thankful > > > into a generic tag. "git log --grep=Thanks" often yields valuable > > > details, beyond just attribution, on how people have helped each other > > > develop this global project of ours. If the introduction of Helped-by > > > would replace even one authentic "Thank you" note with a generic tag > > > then it is a net loss for the community. > > > > I do agree that writing "Thanks John for helping with..." in a patch > > description would be nice, but unfortunately I've seen multiple times > > that people don't enjoy writing their patch descriptions at all, and > > just want to "get them out the door" as quickly as possible. > > > > With that in mind, making Helped-by tags supported would allow such > > people to at least quickly mention someone they're thankful to, which > > actually wouldn't prevent anyone from saying the same more verbosely > > in a patch description. > > Just checking, are there any further thoughts on this patch? I agree with Dan & Jon; we don't need this tag. And if someone's doing a poor job of writing commit messages, they need to be helped to write better ones.
