Re: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Taehee Yoo <ap420073@xxxxxxxxx>
Subject: Re: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Thu, 14 Nov 2024 20:24:09 -0800
Cc: davem@xxxxxxxxxxxxx, pabeni@xxxxxxxxxx, edumazet@xxxxxxxxxx, almasrymina@xxxxxxxxxx, donald.hunter@xxxxxxxxx, corbet@xxxxxxx, michael.chan@xxxxxxxxxxxx, andrew+netdev@xxxxxxx, hawk@xxxxxxxxxx, ilias.apalodimas@xxxxxxxxxx, ast@xxxxxxxxxx, daniel@xxxxxxxxxxxxx, john.fastabend@xxxxxxxxx, dw@xxxxxxxxxxx, sdf@xxxxxxxxxxx, asml.silence@xxxxxxxxx, brett.creeley@xxxxxxx, linux-doc@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, kory.maincent@xxxxxxxxxxx, maxime.chevallier@xxxxxxxxxxx, danieller@xxxxxxxxxx, hengqi@xxxxxxxxxxxxxxxxx, ecree.xilinx@xxxxxxxxx, przemyslaw.kitszel@xxxxxxxxx, hkallweit1@xxxxxxxxx, ahmed.zaki@xxxxxxxxx, rrameshbabu@xxxxxxxxxx, idosch@xxxxxxxxxx, jiri@xxxxxxxxxxx, bigeasy@xxxxxxxxxxxxx, lorenzo@xxxxxxxxxx, jdamato@xxxxxxxxxx, aleksander.lobakin@xxxxxxxxx, kaiyuanz@xxxxxxxxxx, willemb@xxxxxxxxxx, daniel.zahka@xxxxxxxxx
In-reply-to: <20241113173222.372128-5-ap420073@gmail.com>
References: <20241113173222.372128-1-ap420073@gmail.com> <20241113173222.372128-5-ap420073@gmail.com>

On Wed, 13 Nov 2024 17:32:18 +0000 Taehee Yoo wrote:
> +  ``ETHTOOL_A_RINGS_HEADER_DATA_SPLIT_THRESH``      u32     threshold of
> +                                                            header / data split
> +  ``ETHTOOL_A_RINGS_HEADER_DATA_SPLIT_THRESH_MAX``  u32     max threshold of

nit: s/_HEADER_DATA_SPLIT_/_HDS_/ ;)

We can explain in the text that HDS stands for header data split.
Let's not bloat the code with 40+ character names...

Follow-Ups:
- Re: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh
  - From: Taehee Yoo

References:
- [PATCH net-next v5 0/7] bnxt_en: implement tcp-data-split and thresh option
  - From: Taehee Yoo
- [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh
  - From: Taehee Yoo

Prev by Date: Re: [PATCH net-next v5 2/7] net: ethtool: add tcp_data_split_mod member in kernel_ethtool_ringparam
Next by Date: Re: [PATCH v2 1/2] docs: Add debugging section to process
Previous by thread: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh
Next by thread: Re: [PATCH net-next v5 4/7] net: ethtool: add support for configuring header-data-split-thresh
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]